Massive update to tests, add ability to safe setup application config, check further deny subscribers feature.

playpauseandstop · playpauseandstop · commit 9b4a413983a4 · 2012-12-07T11:56:13.000+02:00
diff --git a/learnpython/tests/common.py b/learnpython/tests/common.py
@@ -30,6 +30,7 @@ class TestCase(BaseTestCase):
     Improve base test class from ``Flask-Testing`` with adding ``url`` method
     and ``udata`` property to each test client response.
     """
+    ALLOW_SUBSCRIBERS = True
     BABEL_DEFAULT_LOCALE = 'en'
     CSRF_ENABLED = False
     TESTING = True
@@ -42,6 +43,14 @@ def setUp(self):
         self.status_url = self.url('status')
         self.subscribe_url = self.url('subscribe')
 
+    def tearDown(self):
+        for attr in dir(self):
+            if not attr.startswith('original_'):
+                continue
+
+            key = attr.replace('original_', '')
+            self.app.config[key] = getattr(self, attr)
+
     def check_message(self, message, subject, *args):
         assert len(args) > 2
         name, email = args[:2]
@@ -56,6 +65,10 @@ def check_message(self, message, subject, *args):
         for arg in args:
             self.assertIn(arg, message.body)
 
+    def config(self, key, value):
+        setattr(self, 'original_{0}'.format(key), self.app.config.get(key))
+        self.app.config[key] = value
+
     def create_app(self):
         for attr in dir(self):
             if attr.isupper():
diff --git a/learnpython/tests/test_data.py b/learnpython/tests/test_data.py
@@ -31,7 +31,7 @@ def test_flows(self):
 
     def test_pages(self):
         data = filter(lambda key: not '/' in key, pages._pages.keys())
-        self.assertEqual(len(data), 4)
+        self.assertEqual(len(data), 5)
 
         self.check_page('about')
         self.check_page('contacts')
diff --git a/learnpython/tests/test_flasktesting.py b/learnpython/tests/test_flasktesting.py
@@ -94,6 +94,14 @@ def test_index(self):
         for url in urls:
             self.assertIn('href="{0}"'.format(url), response.data)
 
+    def test_nosubscribe(self):
+        self.config('ALLOW_SUBSCRIBERS', False)
+
+        response = self.client.get(self.subscribe_url)
+        self.assertEqual(response.status_code, 200)
+        self.assertNotIn('<form action="" ', response.data)
+        self.assertIn('<h2>', response.data)
+
     def test_static(self):
         url = self.url('static', filename='css/screen.css')
         response = self.client.get(url)
diff --git a/learnpython/tests/test_twill.py b/learnpython/tests/test_twill.py
@@ -190,6 +190,15 @@ def test_index(self):
             c.code(200)
             c.url(t.url(self.index_url))
 
+    def test_nosubscribe(self):
+        self.config('ALLOW_SUBSCRIBERS', False)
+
+        with Twill(self.app, port=self.port) as (t, c):
+            c.go(t.url(self.subscribe_url))
+            c.code(200)
+            c.notfind('<form action="" ')
+            c.find('<h2>')
+
     def test_static(self):
         url200 = self.url('static', filename='css/screen.css')
         url404 = self.url('static', filename='does_not_exists.exe')
diff --git a/learnpython/tests/test_webtest.py b/learnpython/tests/test_webtest.py
@@ -114,7 +114,7 @@ def test_flows(self):
     def test_index(self):
         self.check_page('index', self.index_url)
 
-        response = self.webtest.get(self.index_url)
+        response = self.webtest.get(self.index_url, status=200)
         doc = response.pyquery
 
         self.assertEqual(len(doc('a.active')), 1)
@@ -125,7 +125,7 @@ def test_index(self):
         self.assertEqual(len(doc('a[href="{0}"]'.format(self.flows_url))), 0)
         self.assertEqual(len(doc('a[href="{0}"]'.format(self.index_url))), 1)
         self.assertEqual(
-            len(doc('a[href="{0}"]'.format(self.subscribe_url))), 3
+            len(doc('a[href="{0}"]'.format(self.subscribe_url))), 2
         )
 
         result = (
@@ -141,6 +141,19 @@ def test_index(self):
         )
         self.check_links(doc('nav a'), result)
 
+    def test_nosubscribe(self):
+        self.config('ALLOW_SUBSCRIBERS', False)
+
+        response = self.webtest.get(self.subscribe_url, status=200)
+        doc = response.pyquery
+
+        self.assertEqual(len(doc('form')), 0)
+        self.assertEqual(len(doc('h2')), 1)
+
+        title = doc('h2')[0]
+        page = pages.get('nosubscribe')
+        self.assertEqual(title.text, page.meta['title'])
+
     def test_static(self):
         url = self.url('static', filename='css/screen.css')
         response = self.webtest.get(url, status=200)
