Skip to content

Commit 8d3ed1d

Browse files
Fix tests.
1 parent e219248 commit 8d3ed1d

6 files changed

Lines changed: 8 additions & 21 deletions

File tree

learnpython/tests/common.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@ class TestCase(BaseTestCase):
2424
Improve base test class from ``Flask-Testing`` with adding ``url`` method
2525
and ``udata`` property to each test client response.
2626
"""
27+
BABEL_DEFAULT_LOCALE = 'en'
2728
CSRF_ENABLED = False
2829
TESTING = True
2930

3031
def setUp(self):
3132
self.about_url = self.url('page', name='about')
3233
self.contacts_url = self.url('contacts')
3334
self.flows_url = self.url('flows')
34-
self.index_url = self.url('page', name='index')
35+
self.index_url = self.url('index')
3536
self.status_url = self.url('status')
3637
self.subscribe_url = self.url('subscribe')
3738

learnpython/tests/test_flask.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,7 @@ def tearDown(self):
1818
self._ctx.pop()
1919

2020
def test_index(self):
21-
index_url = url_for('page', name='index')
22-
index_url_ext = url_for('page', name='index', _external=True)
23-
24-
response = self.client.get('/')
25-
self.assertEqual(response.status_code, 301)
26-
self.assertEqual(response.headers['Location'], index_url_ext)
27-
21+
index_url = url_for('index')
2822
response = self.client.get(index_url)
2923
self.assertEqual(response.status_code, 200)
3024
self.assertIn('Learn Python', response.data)

learnpython/tests/test_flasktesting.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ def test_flows(self):
8282
self.assertIn('id="{0}"'.format(name), response.data)
8383

8484
def test_index(self):
85-
response = self.client.get('/')
86-
self.assertRedirects(response, self.index_url)
87-
self.assertStatus(response, 301)
88-
8985
self.check_page('index', self.index_url)
9086

9187
urls = (self.contacts_url, self.flows_url + '#medium',

learnpython/tests/test_selenium.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ def url(self, url_rule, *args, **kwargs):
5151
return self.host + url
5252

5353
def test_index(self):
54-
index_url = self.url('page', name='index')
54+
index_url = self.url('index')
5555

56-
self.browser.get(self.url('/'))
56+
self.browser.get(index_url)
5757
self.assertEqual(self.browser.current_url, index_url)
5858
time.sleep(1)
5959

learnpython/tests/test_splinter.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,10 @@ def url(self, url_rule, *args, **kwargs):
4444
return self.host + url
4545

4646
def test_index(self):
47-
index_url = self.url('page', name='index')
47+
index_url = self.url('index')
4848

49-
self.browser.visit(self.url('/'))
49+
self.browser.visit(index_url)
5050
self.assertEqual(self.browser.url, index_url)
51-
self.assertEqual(self.browser.title, 'Learn Python in Kyiv, Ukraine')
5251

5352
link = self.browser.find_link_by_text('Learn Python')
5453
self.assertEqual(len(link), 1)

learnpython/tests/test_webtest.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,6 @@ def test_flows(self):
112112
method('active', element.attrib['class'])
113113

114114
def test_index(self):
115-
response = self.webtest.get('/', status=301)
116-
self.assertRedirects(response, self.index_url)
117-
118115
self.check_page('index', self.index_url)
119116

120117
response = self.webtest.get(self.index_url)
@@ -135,7 +132,7 @@ def test_index(self):
135132
(self.about_url, 'About us'),
136133
(self.contacts_url, 'Contacts')
137134
)
138-
self.check_links(doc('header a'), result)
135+
self.check_links(doc('header .left-wrapper p a'), result)
139136

140137
result = (
141138
(self.flows_url + '#medium', 'Medium flow'),

0 commit comments

Comments
 (0)