fix: update PrettyPageHandler.php fix explicit nullable#4
Merged
mychidarko merged 1 commit intoleafsphp:masterfrom Jan 25, 2025
Merged
fix: update PrettyPageHandler.php fix explicit nullable#4mychidarko merged 1 commit intoleafsphp:masterfrom
mychidarko merged 1 commit intoleafsphp:masterfrom
Conversation
Author
|
|
Member
|
Hey @joanhey, thanks for the PR, a lil bit advice when you decide to have a new issue, commit or pr raised there's some contribution standards that need following when doing the above, the title should follow the conventional commits naming convention, and any issue needs to have a description no matter how small it is. cheers. |
ibnsultan
changed the title
Author
|
Now I can update the bench !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
Does this PR introduce a breaking change? (check one)
Related Issue