Draft
Conversation
dctanner
requested changes
Nov 24, 2025
Contributor
dctanner
left a comment
dctanner
left a comment
There was a problem hiding this comment.
Instead of reloading the wavplayer/recorder with new settings, we have decided to refactor how the client sdk loads. It should do all loading of the wavplayer/recorder and sliero after the auth call returns with the config options.
jackbridger
force-pushed
the
main
branch
2 times, most recently
from
6a98e16 to
5571970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable sample rate values that are read from pipeline.config instead of static values.