Replace symlink after removing previous symlink #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The travis-ci build failure seems unrelated to the changes in this PR. The error indicates a missing header file, as follows:
|
Owner
|
I don't like removing the old file without knowing it's a symlink first. Mirror should itself remove the old symlink if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #456.
With this change,
mirror -Rcan replace symlinks over sftp.One side-effect is that
ln -swill also replace symlinks, when this would normally be an error.A better solution would allow
mirror -Rto replace symlinks without changing the behaviour ofln -s. Any suggestions?