Skip to content

Add title function and example of it. - #3

Merged
lava merged 5 commits into
lava:masterfrom
AtsushiSakai:master
Jan 16, 2016
Merged

Add title function and example of it. #3
lava merged 5 commits into
lava:masterfrom
AtsushiSakai:master

Conversation

@AtsushiSakai

Copy link
Copy Markdown
Contributor

No description provided.

lava added a commit that referenced this pull request Jan 16, 2016
Add title function and example of it.
@lava
lava merged commit f5b73c0 into lava:master Jan 16, 2016
@lava

lava commented Jan 16, 2016

Copy link
Copy Markdown
Owner

Nice, thanks for contributing!

Could you explain what you mean by "if PyDECREF, the show function doesn't work on Mac OS"?

@AtsushiSakai

Copy link
Copy Markdown
Contributor Author

Hi, lava. matplotlib-cpp is great. I'm looking for like this : )
The comment means that a figure doesn't show on Mac OS if the PyDECREF function is called at the end of "title" function.
Why do you call PyDECREF on the ends of other functhions?

@lava

lava commented Jan 16, 2016

Copy link
Copy Markdown
Owner

All python objects are reference counted, so in your case you are leaking memory by creating three new objects that will never be removed.

It's a pretty small leak though, so if there is some bug on Mac OS that makes this necessary, I'm willing to just leave it. I don't have a Mac to verify it. Would be nice to know why the figure doesnt show, though.

@AtsushiSakai

Copy link
Copy Markdown
Contributor Author

OK I understand. yeah, I think the leak is not a problem on practical usage.

@AtsushiSakai

Copy link
Copy Markdown
Contributor Author

Thanks for merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants