Add all_flags, secure_mode_hash + more#51
Merged
Merged
Conversation
|
|
||
|
|
||
| def evaluate(flag, user, store, prereq_events=[]): | ||
| def evaluate(flag, user, store): |
Contributor
Author
There was a problem hiding this comment.
I moved all the flag eval logic into the flag file.
|
|
||
| if __name__ == '__main__': | ||
| ldclient._api_key = 'api_key' | ||
| ldclient.api_key = 'api_key' |
Contributor
There was a problem hiding this comment.
Can we change api_key to sdk_key?
Contributor
Author
There was a problem hiding this comment.
I did a wholesale change- including removing the api_key prefix from the auth header.
Contributor
|
👍 |
| send_event(default, flag.get('version')) | ||
| return default | ||
|
|
||
| def all_flags(self, user): |
Contributor
Author
There was a problem hiding this comment.
@jkodumal take note of these checks when implementing in other sdks.
eli-darkly
added a commit
that referenced
this pull request
May 10, 2018
re-add redundant key property in identify event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting client up to speed with: https://catamorphic.quip.com/Ggk6AbylpJBf