Skip to content

Send the toggle default value with flag request events#40

Merged
jkodumal merged 2 commits into
masterfrom
jko/send-default
Feb 2, 2016
Merged

Send the toggle default value with flag request events#40
jkodumal merged 2 commits into
masterfrom
jko/send-default

Conversation

@jkodumal

@jkodumal jkodumal commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@apucacao

apucacao commented Feb 2, 2016

Copy link
Copy Markdown

lgtm

@drichelson

Copy link
Copy Markdown
Contributor

This change looks very lonely.. is there test coverage to make sure this new field shows up?

@pkaeding

pkaeding commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

👍

@jkodumal

jkodumal commented Feb 2, 2016

Copy link
Copy Markdown
Contributor Author

@drichelson thanks for the public shaming on tests. Added :)

jkodumal added a commit that referenced this pull request Feb 2, 2016
Send the toggle default value with flag request events
@jkodumal jkodumal merged commit 7bf786b into master Feb 2, 2016
@jkodumal jkodumal deleted the jko/send-default branch February 2, 2016 23:50
eli-darkly added a commit that referenced this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants