Skip to content

Switch to using compatible requirements everywhere#36

Merged
pkaeding merged 3 commits into
masterfrom
jko/compatible-requirements
May 19, 2016
Merged

Switch to using compatible requirements everywhere#36
pkaeding merged 3 commits into
masterfrom
jko/compatible-requirements

Conversation

@jkodumal

Copy link
Copy Markdown
Contributor

No description provided.

@jkodumal

Copy link
Copy Markdown
Contributor Author

Addresses #35

@albertyw

Copy link
Copy Markdown
Contributor

The current version of requests is 2.9.1 (http://docs.python-requests.org/en/latest/) and requests~=2.4.0 will only allow versions 2.4.*. It would require more testing, but perhaps requests>=2.4.0 is the way to go?

@albertyw

Copy link
Copy Markdown
Contributor

On second thought, until pytest is testing different package versions along with different python versions, it would also be a good idea to set a max version so that a backwards incompatible release doesn't break the client. requests and future are pretty darn stable, but I'm not sure about sseclient and CacheControl.

@albertyw

Copy link
Copy Markdown
Contributor

looks good to me

@pkaeding pkaeding merged commit 4fd3e82 into master May 19, 2016
@pkaeding pkaeding deleted the jko/compatible-requirements branch May 19, 2016 22:57
eli-darkly added a commit that referenced this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants