feat: NO_PROXY environment variable can be used to override HTTP(S)_PROXY values#301
Merged
Conversation
keelerm84
commented
Aug 7, 2024
keelerm84
force-pushed
the
mk/sc-252382/no-proxy
branch
2 times, most recently
from
c6bbbe8 to
0903460
Compare
…)_PROXY` values When determining if a proxy should be used, the SDK would: 1. Check the `config.http_config.http_proxy` value. If that is set, use that value without further consideration. 2. If the target URI is `https`, use the value from the `HTTPS_PROXY` environment variable. 3. If the target is `http`, use `HTTP_PROXY` instead. The SDK will now support another environment variable -- `NO_PROXY`. This variable can be set to a comma-separated list of hosts to exclude from proxy support, or the special case '*' meaning to ignore all hosts. The `NO_PROXY` variable will only take affect if the SDK isn't explicitly configured to use a proxy as specified in #1 above.
keelerm84
force-pushed
the
mk/sc-252382/no-proxy
branch
from
0903460 to
67a6394
Compare
louis-launchdarkly
approved these changes
Aug 16, 2024
keelerm84
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [9.6.0](9.5.0...9.6.0) (2024-08-19) ### Features * `NO_PROXY` environment variable can be used to override `HTTP(S)_PROXY` values ([#301](#301)) ([d0913ee](d0913ee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When determining if a proxy should be used, the SDK would:
config.http_config.http_proxyvalue. If that is set, usethat value without further consideration.
https, use the value from theHTTPS_PROXYenvironment variable.
http, useHTTP_PROXYinstead.The SDK will now support another environment variable --
NO_PROXY.This variable can be set to a comma-separated list of hosts to exclude
from proxy support, or the special case '*' meaning to ignore all hosts.
The
NO_PROXYvariable will only take affect if the SDK isn'texplicitly configured to use a proxy as specified in #1 above.