Skip to content

feat: Redact anonymous attributes within feature events#246

Merged
keelerm84 merged 2 commits into
feat/inline-contextsfrom
mk/sc-228721/anonymous-redaction
Jan 16, 2024
Merged

feat: Redact anonymous attributes within feature events#246
keelerm84 merged 2 commits into
feat/inline-contextsfrom
mk/sc-228721/anonymous-redaction

Conversation

@keelerm84

Copy link
Copy Markdown
Member

No description provided.

@keelerm84 keelerm84 requested a review from a team January 9, 2024 21:04
@shortcut-integration

Copy link
Copy Markdown

This pull request has been linked to Shortcut Story #228721: Anonymous attribute redaction for feature events.

Base automatically changed from mk/sc-223829/inline to feat/inline-contexts January 9, 2024 21:20
@keelerm84 keelerm84 force-pushed the mk/sc-228721/anonymous-redaction branch from 6a796c3 to 50fd009 Compare January 9, 2024 21:23
if ar.valid:
self._private_attributes.append(ar)

def format_context(self, context: Context) -> dict:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on other PRs re: adding a named function, not disturbing existing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also done.

@keelerm84 keelerm84 merged commit 5d4f048 into feat/inline-contexts Jan 16, 2024
@keelerm84 keelerm84 deleted the mk/sc-228721/anonymous-redaction branch January 16, 2024 15:05
keelerm84 pushed a commit that referenced this pull request Mar 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[9.3.0](9.2.2...9.3.0)
(2024-03-14)


### Features

* Inline contexts for all evaluation events
([#245](#245))
([8b5429b](8b5429b))
* Redact anonymous attributes within feature events
([#246](#246))
([4022ee2](4022ee2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants