Prevent HTTPResponse.getheader() is deprecated warning#206
Merged
keelerm84 merged 1 commit intoMay 3, 2023
Conversation
keelerm84
approved these changes
May 3, 2023
Member
|
Thank you for your contribution! I will work on getting a release out as soon as I can with this fix. |
Merged
LaunchDarklyReleaseBot
pushed a commit
that referenced
this pull request
May 3, 2023
(U2C 18) private attribute redaction
Member
|
Fixed in 8.1.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Prevents "DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default)" from happening by updating relevant code to the supported way (
HTTPResponse.headers.get)Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Refer to urllib3/urllib3#2814