Error closing client when LaunchDarkly relay proxy in daemon mode#119
Closed
benpagedelphix wants to merge 1 commit into
Closed
Error closing client when LaunchDarkly relay proxy in daemon mode#119benpagedelphix wants to merge 1 commit into
benpagedelphix wants to merge 1 commit into
Conversation
Contributor
|
This definitely needs to be fixed, but I think we're going to go in a slightly different direction: making sure that all of the object's attributes are always set at initialization time, so we don't need to go "check this other attribute first because if it has a certain value, then the attribute I want won't exist." In other words, the |
Author
|
That makes sense to me, thanks for fixing this ASAP |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Nov 21, 2019
add Python 3.8 CI build, and make syntax warnings fatal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not attempt to read the
_update_processorattribute when closing theclientif the client is running inlddmode because initialization of the_update_processorattribute does not occur ifuse_lddis set to true in the config.