Skip to content

prepare 6.8.4 release#116

Merged
eli-darkly merged 138 commits into
masterfrom
6.8.4
Mar 29, 2019
Merged

prepare 6.8.4 release#116
eli-darkly merged 138 commits into
masterfrom
6.8.4

Conversation

@eli-darkly

Copy link
Copy Markdown
Contributor

[6.8.4] - 2019-03-29

Fixed:

  • Setting user attributes to non-string values when a string was expected would cause analytics events not to be processed. Also, in the case of the "secondary" attribute, this could cause evaluations to fail for a flag with a percentage rollout. The SDK will now convert attribute values to strings as needed. (#115)
  • If track or identify is called without a user, the SDK now logs a warning, and does not send an analytics event to LaunchDarkly (since it would not be processed without a user).

eli-darkly and others added 30 commits October 4, 2018 19:17
add option to reduce front-end metadata for untracked flags
fix logic for whether a flag is tracked in all_flags_state
@eli-darkly eli-darkly requested a review from torchhound March 29, 2019 19:17
Comment thread ldclient/flag.py

__USER_ATTRS_TO_STRINGIFY_FOR_EVALUATION__ = [ "key", "secondary" ]
# Currently we are not stringifying the rest of the built-in attributes prior to evaluation, only for events.
# This is because it could affect evaluation results for existing users (ch35206).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose a clubhouse ticket number?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not. It's not sensitive information and it may be helpful to us later.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, just checking.

@torchhound torchhound left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eli-darkly eli-darkly merged commit fce57ca into master Mar 29, 2019
@eli-darkly eli-darkly deleted the 6.8.4 branch March 29, 2019 21:13
LaunchDarklyCI pushed a commit that referenced this pull request Oct 30, 2019
(re)implement setting proxy URL by environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants