-
Notifications
You must be signed in to change notification settings - Fork 62
Fix for QuickFix for vscode.Diagnostic.code #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for QuickFix for vscode.Diagnostic.code #513
Conversation
|
@N1ebieski thanks for reporting this - this totally makes sense. What linter or setup are you using that causes it to send a number or an object? |
|
Hi @TitasGailius, I'm using WSL Linux with Docker and working with the extension in dev container mode. For me, it's only an object, not a number. |
|
@N1ebieski There must be another extension, a special rule in An easy way to check where this is coming from is by inspecting the The reason I'm asking is that it doesn't seem to be provided by the Laravel Extension itself, and I'd like to understand the actual source. |
|
@N1ebieski interesting. Thanks for checking. |
|
@N1ebieski, your version of the extension includes these changes: The |
|
@TitasGailius You're right. On the |
|
@TitasGailius OK this is why > https://github.com/laravel/vs-code-extension/pull/443/files#diff-cba9592099e8717965c26e4a4fbf5f49ec33850cb90f8750e555ed4ddf35cd15R94-R97 Please let me know whether I should remove these links and keep only the Quick Fix option:
If so, this PR can be closed. |


Currently the QuickFix option doesn't work for me:
This is because
vscode.Diagnostic.codecan be one of the following:However, the extension currently checks only for a string value (and not a number or an object): https://github.com/laravel/vs-code-extension/blob/main/src/features/env.ts#L200-L202
This PR fixes the issue for the
env,viewandinertiahelpers.