Repository navigation
[13.x] Harden HTTP client request and fake response serialization - #60522
Merged
Merged
Conversation
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 1, 2026
An integer URL stub outside 100-599 now throws InvalidArgumentException instead of being used as a response body. Laravel documents that on stubUrl(), and Hypervel now does too. The other InvalidArgumentException annotations from the same Laravel change were already present on the fake response and request normalization methods. Laravel: laravel/framework#60522 Laravel: laravel/framework#60546 Source: laravel/framework master cd6e81dff3ba7a4564ac88c3949698c728d20109 Validation: HttpClientTest and FacadeDocblocksTest pass; the Http facade is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should avoid PHP 8.5 deprecation warnings about casting non-finite floats to strings, upcoming deprecations in the Guzzle 7.12/PSR 2.12 releases I am likely to do later today, and to ensure consistent errors when there's invalid input.