Skip to content

fallback to fallback_locale translation when empty string #34128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahmedsayedabdelsalam wants to merge 1 commit into from
Closed

fallback to fallback_locale translation when empty string #34128

ahmedsayedabdelsalam wants to merge 1 commit into from

Conversation

@ahmedsayedabdelsalam
Copy link
Contributor

@ahmedsayedabdelsalam ahmedsayedabdelsalam commented Sep 4, 2020

// ar
'foo' => ''
// en
'foo', => 'bar'

before
trans('file.foo',[],'ar') // ''

after
trans('file.foo',[],'ar') // 'bar'

@GrahamCampbell
Copy link
Collaborator

GrahamCampbell commented Sep 4, 2020

Please send this to 6.x, since this is a bug fix. :)

@ahmedsayedabdelsalam ahmedsayedabdelsalam mentioned this pull request Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedsayedabdelsalam @GrahamCampbell