Skip to content

Conversation

@BrandonSurowiec
Copy link
Contributor

Noticed the Paginator Contract incorrectly uses "is", while the implementation correctly uses "are."

    /**
     * Determine if there is more items in the data store.
     *
     * @return bool
     */
    public function hasMorePages();

    /**
     * Determine if there are more items in the data source.
     *
     * @return bool
     */
    public function hasMorePages()
    {
        return $this->currentPage() < $this->lastPage();
    }

@driesvints driesvints merged commit b75387b into laravel:6.x Aug 28, 2020
@driesvints
Copy link
Member

Thanks!

@BrandonSurowiec BrandonSurowiec deleted the patch-3 branch August 28, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants