Skip to content

refactor(web): share workflow comment queries and mutations - #44372

Draft
jinchuntan wants to merge 1 commit into
langgenius:mainfrom
jinchuntan:refactor/workflow-comments-query
Draft

jinchuntan wants to merge 1 commit into
langgenius:mainfrom
jinchuntan:refactor/workflow-comments-query

Conversation

@jinchuntan

Copy link
Copy Markdown

Part of #38351.

Move workflow comment lists and thread details into app-scoped Query caches, replacing the Zustand copies. Generated mutations now share invalidation and pending states across editor consumers. Selection and canvas interaction stay in the editor store.

This avoids duplicate initial reads, ignores other apps' collaboration events, and keeps a failed move from rolling back another comment's newer data. Keyboard focus, mentions, replies and deletion remain covered.

Validation:

  • 178 related tests passed, including 22 comment-hook tests using the real generated client and request transport with stubbed HTTP responses.
  • Three regressions fail on the original implementation.
  • Changed-file formatting, lint and type checks passed with no warnings. Repository formatting, ESLint and git diff --check also passed.
  • Full-repository analysis was stopped at 7 GiB memory use under this workspace's 8 GiB limit.

Draft pending author review.

From Codex

@github-actions github-actions Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. web This relates to changes on the web. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant