fix(python): accept pathlib.Path in get_uri_scheme and get_uri_location - #4132
Open
Tyagiquamar wants to merge 4 commits into
Open
fix(python): accept pathlib.Path in get_uri_scheme and get_uri_location#4132Tyagiquamar wants to merge 4 commits into
Tyagiquamar wants to merge 4 commits into
Conversation
Converts uri parameter to string before calling urlparse, allowing pathlib.Path objects to be passed without raising TypeError.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![lancedb-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4497274?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lancedb-gatekeeper
Bot
added
the
K-changes
lancedb-gatekeeper
Bot
removed
the
K-changes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lancedb-gatekeeper
Bot
added
the
K-changes
…ation expectation
lancedb-gatekeeper
Bot
removed
the
K-changes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lancedb-gatekeeper
Bot
added
K-approved
Author
|
Hi, friendly ping for review on this PR when you have a moment. Happy to address any feedback. Thanks! |
lancedb-gatekeeper
Bot
removed
the
K-approved
lancedb-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the uri parameter to string before calling urlparse in get_uri_scheme and get_uri_location, allowing pathlib.Path objects to be passed seamlessly without raising a TypeError.