fix(python): decode file URIs in OpenCLIP - #4131
Open
yhz5613813 wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
yhz5613813
force-pushed
the
fix/openclip-file-uri-decoding
branch
from
September 5, 2026 07:49
ca764b2 to
cf94494
Compare
![lancedb-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4497274?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Gate recommendation: approve.
This fixes the failure at the URI-to-native-path boundary: file: URI paths are converted with the standard-library native-path helper before Pillow receives them, while plain paths and HTTP URLs retain their existing behavior. The regression test covers the encoded local-filename case.
lancedb-gatekeeper
Bot
added
the
K-approved
wjones127
self-requested a review
September 8, 2026 20:47
wjones127
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Decode the path component of
file://image URIs before passing it to Pillow.Why
Path.as_uri()percent-encodes characters such as spaces. Passingparsed.pathdirectly to Pillow therefore tries to open a literal%20path and fails.Testing
compileallon both changed files.