feat: default create_index to create-only - #4124
Draft
ChilePiquin wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
✅ Gate recommendation: approve.
2 fixed / 0 remain. The revision now sets create-only behavior at the shared builder boundary, keeps local, remote, Python, and TypeScript contracts aligned, and preserves explicit replacement through the existing remote contract established in #4115. Keeping duplicate rejection at the backend operation avoids a racy client-side existence check.
The repaired request fixtures and generated API reference match the new behavior; no further changes are requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
create_indexto be create-only by default in LanceDB. Before this change, omittingreplacecould rebuild an existing index, which made duplicate create calls surprising when callers only meant to create a new index. The new default isreplace=false; callers that want to rebuild an existing index must passreplace=trueexplicitly. This is an intentional breaking behavior change for duplicate index creation.This was accomplished with the following changes:
IndexBuilder::newnow initializesreplacetofalse, so Rust/local index creation defaults to create-only.RemoteTable::submit_create_indexalways serializesreplace, preserving both the new default and explicitreplace=true.replacetoFalseand pass that value through consistently.rust/lancedb/src/job.rsare gated behind theremotefeature so default-feature builds compile cleanly.Testing