feat(rust): split bad vector handling into value and dimension controls#3355
Open
Mesut-Doner wants to merge 1 commit into
Open
feat(rust): split bad vector handling into value and dimension controls#3355Mesut-Doner wants to merge 1 commit into
Mesut-Doner wants to merge 1 commit into
Conversation
Replace NaNVectorBehavior (Error/Keep) with two independent enums: - BadVectorValueHandling — handles NaN values in vectors (Error/Drop/Null/Fill/Keep) - BadVectorDimensionHandling — handles wrong-dimension vectors before List→FSL cast (Error/Drop/Null/Fill) Pipeline order: ScannableExec → handle_bad_dimensions → cast → handle_bad_values. Both strategies are implemented as DataFusion physical plan nodes using scalar UDFs. Deprecated on_nan_vectors() wraps the new API for one release cycle. Fixes lancedb#992.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace NaNVectorBehavior (Error/Keep) with two independent enums:
on_bad_vectorsbehavior to rust #992.