Improved code readability and RFC compliance#2795
Closed
suwakei wants to merge 1 commit intolabstack:masterfrom
Closed
Improved code readability and RFC compliance#2795suwakei wants to merge 1 commit intolabstack:masterfrom
suwakei wants to merge 1 commit intolabstack:masterfrom
Conversation
Author
|
Hi maintainers 👋 |
Contributor
|
Vish and Claude AI fixed same thing in #2825 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
1. Improved parsing of authentication information:
I currently use a for loop to split username and password, but we believe that using strings.Cut, available in Go 1.18 or later, would make the code simpler and more readable.
2. Added Realm quoting in WWW-Authenticate header:
RFC 7617 requires that the value of the realm parameter be a quoted-string. In the current implementation, the default realm is unquoted. You can comply with this specification by always using strconv.Quote
These changes will further improve the robustness and maintainability of the middleware.