CORS middleware should compile allowOrigin regexp at creation#2709
Merged
aldas merged 1 commit intolabstack:masterfrom Nov 22, 2024
Merged
CORS middleware should compile allowOrigin regexp at creation#2709aldas merged 1 commit intolabstack:masterfrom
aldas merged 1 commit intolabstack:masterfrom
Conversation
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change preserves previous behavior - invalid patterns are just ignored.
we can not add panics as this would cause runtime unrecovered panics (i.e. some people very angry as their applications crash at prod)
Reported by #2708