Remove unneeded/duplicate jwt middleware in favor of https://github.com/labstack/echo-jwt#2508
Remove unneeded/duplicate jwt middleware in favor of https://github.com/labstack/echo-jwt#2508bakatz wants to merge 1 commit intolabstack:masterfrom
Conversation
|
@aldas it looks like you might have been the creator of the echo-jwt repo. Curious for your thoughts on this PR - did I miss anything or does this seem reasonable to merge? |
|
We can not remove JWT middleware from this repo due backwards compatibility promises we are trying to keep. https://github.com/labstack/echo-jwt was created just for this reason - we could do these kind of changes. I do not remember exactly but I think seeing linters/checks warning about deprecation notices like Line 158 in 77d5ae6 |
|
@aldas
Let me know what you think EDIT: my first 2 points are somewhat mitigated - seems like after restarting vs code it recognized the deprecated method, behavior seems to be flaky though. |
2 participants
I was looking at one of my projects and realized there was an old JWT library reference in there. Then I realized that echo still uses some old version of the jwt middleware baked into the echo repo, while simultaneously noting that https://github.com/labstack/echo-jwt is the officially supported jwt middleware library.
Problem: I think this is a confusing strategy - why not just recommend the use of https://github.com/labstack/echo-jwt instead of having 2 separate jwt middlewares, one baked into the echo lib itself with an old version of the jwt lib?
This PR removes the old jwt middleware with an old version of golang-jwt and updates dependencies.
I would recommend a minor or major version bump and just ask people to use the echo-jwt library as it uses the latest JWT version and is otherwise exactly the same code.