Merged
Conversation
Contributor
aldas
requested changes
Nov 30, 2022
middleware/logger_test.go
Outdated
| Format: `{"time":"${time_rfc3339_nano}","id":"${id}","remote_ip":"${remote_ip}","host":"${host}","user_agent":"${user_agent}",` + | ||
| `"method":"${method}","uri":"${uri}","status":${status}, "latency":${latency},` + | ||
| `"latency_human":"${latency_human}","bytes_in":${bytes_in}, "path":"${path}", "referer":"${referer}",` + | ||
| `"latency_human":"${latency_human}","bytes_in":${bytes_in}, "path":"${path}", "route":"${route}" "referer":"${referer}",` + |
Contributor
There was a problem hiding this comment.
to be pedantic :) , comma is missing between route and referer. otherwise this is OK PR
Contributor
Author
There was a problem hiding this comment.
Oh thanks for the good catch, fixed🙏
10a35c5
Codecov ReportBase: 92.20% // Head: 92.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2162 +/- ##
==========================================
+ Coverage 92.20% 92.69% +0.49%
==========================================
Files 37 37
Lines 3090 4462 +1372
==========================================
+ Hits 2849 4136 +1287
- Misses 151 238 +87
+ Partials 90 88 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
routeto tags used for request logging to be able to log the route pattern.There is a usecase that we want to log the route to aggregate the request in monitoring.