Skip to content
This repository was archived by the owner on Nov 23, 2021. It is now read-only.

Prepare for the removal of artifacts directories next #79

Closed
JohnNiang wants to merge 5 commits into from
Closed

Prepare for the removal of artifacts directories next #79

JohnNiang wants to merge 5 commits into from

Conversation

@JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Apr 22, 2021 •
edited
Loading

I removed artifacts/m2 folder according to this instruction: https://docs.github.com/en/github/authenticating-to-github/removing-sensitive-data-from-a-repository.

This PR is aimed to prepare for the removal of artifacts directories next.

What needs to be noted here is what needs to be done after the merge:

  1. Clone devops-java-sample with mirror flag.
git clone --mirror git@github.com:kubesphere/devops-java-sample.git
  1. Download https://repo1.maven.org/maven2/com/madgag/bfg/1.14.0/bfg-1.14.0.jar
wget -c https://repo1.maven.org/maven2/com/madgag/bfg/1.14.0/bfg-1.14.0.jar -P ~/Downloads
  1. Go into devops-java-sample repo
  2. Delete artifacts folder
java -jar ~/Downloads/bfg-1.14.0.jar --delete-folders artifacts --delete-files artifacts --no-blob-protection .
  1. Garbage collection
git reflog expire --expire=now --all && git gc --prune=now --aggressive
  1. Push and update all refs on remote server
git push

Before:

--- /home/johnniang/Workspaces/johnniang/devops-java-sample --------
  114.9 MiB [##########] /artifacts                                                                      
   69.2 MiB [######    ] /.git
   64.0 KiB [          ] /deploy
   56.0 KiB [          ] /src
   12.0 KiB [          ]  LICENSE
    8.0 KiB [          ]  README.md
    8.0 KiB [          ] /configuration
    8.0 KiB [          ] /.s2i
    8.0 KiB [          ]  pom.xml
    4.0 KiB [          ]  Jenkinsfile-on-prem
    4.0 KiB [          ]  Jenkinsfile-online
    4.0 KiB [          ]  Dockerfile-on-prem
    4.0 KiB [          ]  Dockerfile-online
    4.0 KiB [          ]  OWNERS
    4.0 KiB [          ]  .gitignore

The result:

--- /home/johnniang/workspace/kubesphere/devops-java-sample ---------
  272.0 KiB [##########] /.git
   64.0 KiB [##        ] /deploy
   56.0 KiB [##        ] /src
   12.0 KiB [          ]  LICENSE
    8.0 KiB [          ]  README.md
    8.0 KiB [          ] /configuration
    8.0 KiB [          ] /.s2i
    8.0 KiB [          ]  pom.xml
    4.0 KiB [          ]  Jenkinsfile-on-prem
    4.0 KiB [          ]  Jenkinsfile-online
    4.0 KiB [          ]  Dockerfile-on-prem
    4.0 KiB [          ]  OWNERS
    4.0 KiB [          ]  Dockerfile-online
    4.0 KiB [          ]  .gitignore

Close #76
Close #74

/kind optimization

@ks-ci-bot
Copy link
Collaborator

ks-ci-bot commented Apr 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnNiang
To complete the pull request process, please assign shaowenchen
You can assign the PR to them by writing /assign @shaowenchen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang changed the title Perf/remove artifacts folder Remove artifacts folder for performance Apr 22, 2021
@JohnNiang JohnNiang mentioned this pull request Apr 22, 2021
Closed
@ks-ci-bot
Copy link
Collaborator

ks-ci-bot commented Apr 23, 2021

The following users are mentioned in OWNERS file(s) but are not members of the kubesphere org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • runzexia
    • OWNERS

LinuxSuRen
LinuxSuRen suggested changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. And please fix the conflicts.

Dockerfile-on-prem

COPY target/*.jar /home

ENTRYPOINT java -jar *.jar
Copy link
Collaborator

@LinuxSuRen LinuxSuRen Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using wildcards here?

Dockerfile-on-prem
@@ -0,0 +1,9 @@
FROM harbor.devops.kubesphere.local:30280/library/java:openjdk-8-jre-alpine
Copy link
Collaborator

@LinuxSuRen LinuxSuRen Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend that providing some description about the purpose of this file here.

Copy link
Collaborator

@LinuxSuRen LinuxSuRen Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the base image harbor.devops.kubesphere.local:30280/library/java:openjdk-8-jre-alpine comes from?

Copy link
Member Author

@JohnNiang JohnNiang Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make a tutorial about devops hand's lab in offline mode.

Dockerfile-online

COPY target/*.jar /home

ENTRYPOINT java -jar *.jar
Copy link
Collaborator

@LinuxSuRen LinuxSuRen Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using wildcards here?

Copy link
Member Author

@JohnNiang JohnNiang Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause we couldn't know the specific jar name directly. If you have any better suggestions, you can come up with them.

@JohnNiang
Copy link
Member Author

JohnNiang commented Apr 27, 2021

Thanks for your review. I'll fix them as soon as possible.

@JohnNiang
Add github workflow support
68f1194 
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang
Add Dockerfile-cache
119c86d 
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang
Update Jenkinsfile
9085e8c 
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang
Make aliyun mirror be the first choice
0b78870 
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang JohnNiang force-pushed the perf/remove-artifacts-folder branch from bda26a9 to 0b78870 Compare April 29, 2021 14:52
@JohnNiang
Ignore artifacts folder
d18f8e3 
Signed-off-by: johnniang <johnniang@fastmail.com>
@JohnNiang JohnNiang changed the title Remove artifacts folder for performance Prepare to remove artifacts folder for performance Apr 29, 2021
@JohnNiang JohnNiang changed the title Prepare to remove artifacts folder for performance Prepare for the removal of artifacts directories next Apr 29, 2021
@LinuxSuRen
Copy link
Collaborator

LinuxSuRen commented Sep 25, 2021

There're too many people who are creating PRs for test purposes. I'm going to close all PRs. And try to disable the PR feature.

And we can maintain the sample project in another ways.

@LinuxSuRen LinuxSuRen closed this Sep 25, 2021
@JohnNiang JohnNiang deleted the perf/remove-artifacts-folder branch September 25, 2021 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dco-signoff: yes do-not-merge/invalid-owners-file kind/optimization size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I want to know what the artifacts/m2 folder is for This repo is too big due to having the maven local cache files

3 participants

@JohnNiang @ks-ci-bot @LinuxSuRen