Skip to content
This repository was archived by the owner on Nov 23, 2021. It is now read-only.

Conversation

@Felixnoo
Copy link

Signed-off-by: Felixnoo felixliu@yunify.com

Signed-off-by: Felixnoo <felixliu@yunify.com>
@Felixnoo
Copy link
Author

/assign @LinuxSuRen
/assign @FeynmanZhou
I modified the README file. Please take a look when you are available, thanks.

@FeynmanZhou
Copy link
Contributor

/lgtm. I agree with these changes. We just need to maintain the documents on the official website only.

Copy link
Collaborator

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the English version of the README file. But I'd prefer to have them both instead of removing the Chinese version.

By the way, I believe this PR could fix #75. Normally, we use the following comment to close the corresponding issues.

fix #75

@LinuxSuRen
Copy link
Collaborator

/retitle Provide an English version of the README file

@ks-ci-bot ks-ci-bot changed the title Readme modified. Provide an English version of the README file Apr 19, 2021
Copy link
Collaborator

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm label Apr 19, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Felixnoo, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved and removed lgtm labels Apr 19, 2021
Signed-off-by: Felixnoo <felixliu@yunify.com>
@Felixnoo
Copy link
Author

/assign @LinuxSuRen Hi, ZH README added. Please take a look.

@LinuxSuRen
Copy link
Collaborator

/lgtm

Try not to use force-push. It's very hard to know what changes have you made.

@ks-ci-bot ks-ci-bot added the lgtm label Apr 19, 2021
@ks-ci-bot ks-ci-bot merged commit 7ba822d into kubesphere:master Apr 19, 2021
@LinuxSuRen
Copy link
Collaborator

By the way, I believe this PR could fix #75. Normally, we use the following comment to close the corresponding issues.

hi @Felixnoo , As you can see, if you don't it like I suggested. The corresponding issue #75 cannot be closed automatically.

@Felixnoo
Copy link
Author

By the way, I believe this PR could fix #75. Normally, we use the following comment to close the corresponding issues.

hi @Felixnoo , As you can see, if you don't it like I suggested. The corresponding issue #75 cannot be closed automatically.

I thought I need to wait for the lgtm label before I add #75 in my comment. I'll add it in time in future PRs.
BTW, I just made minor format changes so I used force-push to clean my commit history. I'll try not to use it in future PRs.

@LinuxSuRen
Copy link
Collaborator

I thought I need to wait for the lgtm label before I add #75 in my comment. I'll add it in time in future PRs.

Usually, we put that kind of comment at the beginning of the PR. So GitHub will close the corresponding issue once the PR gets merged.

BTW, I just made minor format changes so I used force-push to clean my commit history. I'll try not to use it in future PRs.

Got you. Prow can squash the commit history automatically, see also kubesphere-retired/prow-tutorial#30

Anyway, thanks for your contribution. So glad we can have a better descriptive README file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants