-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Provide an English version of the README file #77
Conversation
Signed-off-by: Felixnoo <felixliu@yunify.com>
|
/assign @LinuxSuRen |
|
/lgtm. I agree with these changes. We just need to maintain the documents on the official website only. |
LinuxSuRen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the English version of the README file. But I'd prefer to have them both instead of removing the Chinese version.
By the way, I believe this PR could fix #75. Normally, we use the following comment to close the corresponding issues.
fix #75
|
/retitle Provide an English version of the README file |
LinuxSuRen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Felixnoo, LinuxSuRen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felixnoo <felixliu@yunify.com>
|
/assign @LinuxSuRen Hi, ZH README added. Please take a look. |
|
/lgtm Try not to use |
I thought I need to wait for the lgtm label before I add |
Usually, we put that kind of comment at the beginning of the PR. So GitHub will close the corresponding issue once the PR gets merged.
Got you. Prow can squash the commit history automatically, see also kubesphere-retired/prow-tutorial#30 Anyway, thanks for your contribution. So glad we can have a better descriptive README file. |
Signed-off-by: Felixnoo felixliu@yunify.com