Correct the wrong order number in the readme file #66
Conversation
Signed-off-by: PeiHongbing1223 <peihongbing1223@gmail.com>
Signed-off-by: PeiHongbing1223 <peihongbing1223@gmail.com>
Signed-off-by: PeiHongbing1223 <peihongbing1223@gmail.com>
|
|
||
| ```yaml | ||
| stage('push latest'){ | ||
| when{ | ||
| branch 'master' | ||
| } | ||
| steps{ | ||
| container ('maven') { | ||
| sh 'docker tag $REGISTRY/$DOCKERHUB_NAMESPACE/$APP_NAME:SNAPSHOT-$BRANCH_NAME-$BUILD_NUMBER $REGISTRY/$DOCKERHUB_NAMESPACE/$APP_NAME:latest ' | ||
| sh 'docker push $REGISTRY/$DOCKERHUB_NAMESPACE/$APP_NAME:latest ' | ||
| } | ||
| } | ||
| } | ||
|
|
||
| ``` |
There was a problem hiding this comment.
I prefer to keep this part.
|
In order to make the PR title be more meaningful. I'd like to rewrite it. Please correct me if you have a better one. /retitle Correct the wrong order number in the readme file |
PeiHongbing1223
left a comment
PeiHongbing1223
left a comment
There was a problem hiding this comment.
I think the title "Correct the wrong order number in the readme file" is very good, you can modify it directly, thank you.
|
/lgtm |
|
/cc @kubesphere/sig-devops |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LinuxSuRen, PeiHongbing1223, shaowenchen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Refine the readme file