Skip to content

docs(core-dns): update tutorial #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

docs(core-dns): update tutorial #5926

wants to merge 5 commits into from
+582 −321

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Oct 26, 2025

What does it do ?

  • move coredns tutorial to it's own file to keep tutorial and provider configuration separated

Motivation

  • tutorial was outdated
  • helm charts and other values where not correct or charts no longer exist or maintaned

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@ivankatliarchuk
docs(core-dns): update tutorial
b494997 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from szuecs October 26, 2025 11:57
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2025
@ivankatliarchuk
docs(core-dns): update tutorial
5ae2181 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
docs(core-dns): update tutorial
c1d1b2c 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@coveralls
Copy link

coveralls commented Oct 26, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18817711951

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 78.661%
Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 79.49%
Totals Coverage Status
Change from base Build 18815330014: -0.005%
Covered Lines: 15862
Relevant Lines: 20165
💛 - Coveralls

@ivankatliarchuk
docs(core-dns): update tutorial
c08cd48 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
docs(core-dns): update tutorial
990067a 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@szuecs
Copy link
Contributor

szuecs commented Oct 31, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivankatliarchuk @coveralls @szuecs @k8s-ci-robot