Add kubernetes-client/python-base as submodule to this repo#222
Merged
Conversation
sebgoa
reviewed
May 19, 2017
sebgoa
left a comment
sebgoa
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me. I did not pay attention to the change, but it looks good. I suppose the move is not finished yet.
FWIW the python setup.py install gave me issues on 2.7.
I installed with pip install -e . after having initialized the submodule with git submodule update --init --recursive. The README might need some adjusting.
Contributor
Author
|
I see |
yliaog
pushed a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
…labels configmap e2e: use labels and label selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to restructure python client according to https://github.com/kubernetes-client/community/blob/master/design-docs/clients-library-structure.md
for that purpose, base folder is moved to the other repo.