Fix error handling.#697
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
ci unhappy @brendandburns |
|
CI is fixed now, please take a look. Thanks! |
| synchronized (ExecProcess.this) { | ||
| // Try for a pretty unique error code, so if someone searches they'll find this | ||
| // code. | ||
| statusCode = -1975219; |
There was a problem hiding this comment.
https://tools.ietf.org/html/rfc6455#section-7.4
3000-3999
Status codes in the range 3000-3999 are reserved for use by
libraries, frameworks, and applications. These status codes are
registered directly with IANA. The interpretation of these codes
is undefined by this protocol.
according to the RFC, negative status code doesn't seem recommended.. how about a unique number ranged in 3000-3999?
There was a problem hiding this comment.
This is a proces status code, not an HTTP/WebSocket status code. I think a process status code can be whatever you want it to be (and negative numbers are definitely allowed.)
There was a problem hiding this comment.
oh tricked.. yes it's exit code from remote process.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
3 participants
Fixes #686
cc @ceeaspb please see if this addresses your issue.