Skip to content

Addons: helm based addons #21847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Addons: helm based addons #21847

wants to merge 2 commits into from
+237 −41

Conversation

@volatilemolotov
Copy link
Contributor

@volatilemolotov volatilemolotov commented Nov 4, 2025

This PR adds support for addons based on helm.

Adds the following:

  • helmChart struct to addon. If this is defined code will go to helmCommand . If set to nil regular kubectl addon install happens
  • helmInstall is triggered which installs the helm binary based on arch. This was done to not add bloat to the binary/iso
  • uses values and value files to set --set and --values respectively. This way one can ship a value file to configure via embed.FS

Example impelentation:

In addons list in pkg/minikube/assets/addons.go

		"testaddon": NewAddon([]*BinAsset{
   	MustBinAsset(addons.TestAddonAssets, "test-addon/test-addon.yaml", vmpath.GuestAddonsDir, "test-addon-values.yaml", "0640"),
   	}, false, "testaddon", "3rd party (akvelon.com)", "volatilemolotov", "", nil, nil,
   	&HelmChart{
   		Name:      "testaddon",
   		Repo:      "oci://linktooci/chart",
   		Namespace: "testaddon",
   		Values:    []string{"service.type=NodePort"},
   		ValueFiles: []string{"/etc/kubernetes/addons/test-addon-values.yaml",},
   	},

Provides foundation for #21257

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: volatilemolotov
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nirs November 4, 2025 22:11
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

Hi @volatilemolotov. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2025
@minikube-bot
Copy link
Collaborator

minikube-bot commented Nov 4, 2025

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@nirs nirs Awaiting requested review from nirs

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@volatilemolotov @k8s-ci-robot @minikube-bot