Skip to content

fix: allow job startTime updates on resume from suspended state (automated cherry-pick to v1.32) #135128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-1.32
Choose a base branch
from
Open

fix: allow job startTime updates on resume from suspended state (automated cherry-pick to v1.32) #135128

wants to merge 1 commit into from
+121 −1

Conversation

@dejanzele
Copy link
Contributor

@dejanzele dejanzele commented Nov 5, 2025

What type of PR is this?

/kind bug
/sig apps

What this PR does / why we need it:

This is an automated cherry-pick of the bugfix which affects k8s versions starting from v1.32.

Which issue(s) this PR is related to:

Fixes #134521

KEP: kubernetes/enhancements#4368

Special notes for your reviewer:

This is a blocker for promoting Job API managed-by mechanism to GA.

Does this PR introduce a user-facing change?

Fix the bug which could result in Job status updates failing with the error:
status.startTime: Required value: startTime cannot be removed for unsuspended job
The error could be raised after a Job is resumed, if started and suspended previously.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@dejanzele
fix: allow job startTime updates on resume from suspended state
7b40e37 
Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Nov 5, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2025
@dejanzele
Copy link
Contributor Author

dejanzele commented Nov 5, 2025

/cc @kannon92 @mimowo @soltysh

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2025
@dejanzele dejanzele changed the title fix: allow job startTime updates on resume from suspended state fix: allow job startTime updates on resume from suspended state (automated cherry-pick to v1.32) Nov 5, 2025
soltysh
soltysh approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

LGTM label has been added.

Git tree hash: b8ebd022cf6a1b6de321b84a147c581d70c28003

@soltysh
Copy link
Contributor

soltysh commented Nov 5, 2025

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 5, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 5, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2025

/lgtm
/approve
From Job maintainer PoV

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dejanzele, mimowo, soltysh
Once this PR has been reviewed and has the lgtm label, please assign smarterclayton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@kannon92 kannon92 Awaiting requested review from kannon92

@mimowo mimowo Awaiting requested review from mimowo

@deads2k deads2k Awaiting requested review from deads2k

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@soltysh soltysh

@mimowo mimowo

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Apps
Status: Needs Triage

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

4 participants

@dejanzele @k8s-ci-robot @soltysh @mimowo