Skip to content

Fix HasHighlyAvailableControlPlane to use AllInstanceGroups #17740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix HasHighlyAvailableControlPlane to use AllInstanceGroups #17740

wants to merge 1 commit into from
+129 −1

Conversation

@pkubicsek-sb
Copy link

@pkubicsek-sb pkubicsek-sb commented Nov 3, 2025

What this PR does / why we need it:

Fixes a bug where HasHighlyAvailableControlPlane() incorrectly uses the filtered InstanceGroups list instead of AllInstanceGroups. This causes cluster-wide controllers (aws-load-balancer-controller, node-termination-handler, etc.) to incorrectly downscale from 2 to 1 replica when running kops update cluster with --instance-group or --instance-group-roles filters on HA clusters.

The fix changes the function to use AllInstanceGroups since HA status is a cluster-wide property that should not depend on instance group filtering.

Which issue(s) this PR fixes:
Fixes #17739

Special notes for your reviewer:

  • Added unit tests including a regression test for the filtered instance groups scenario
  • The bug only manifests when using --instance-group or --instance-group-roles flags
  • Change is minimal: single line change in template_functions.go:502

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 3, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 3, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pkubicsek-sb / name: Peter Kubicsek (e6786c2)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

Welcome @pkubicsek-sb!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

Hi @pkubicsek-sb. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rifelpet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pkubicsek-sb pkubicsek-sb force-pushed the fix-ha-detection-with-instance-group-filter branch from 05cbb11 to c3189b5 Compare November 3, 2025 18:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2025
@pkubicsek-sb
Fix HasHighlyAvailableControlPlane to use AllInstanceGroups
e6786c2 
When using 'kops update cluster' with --instance-group or
--instance-group-roles filters, the HasHighlyAvailableControlPlane
function was incorrectly using the filtered InstanceGroups list
instead of AllInstanceGroups.

This caused cluster-wide controllers like aws-load-balancer-controller
and node-termination-handler to incorrectly downscale replicas from 2
to 1 when updating a specific instance group in an HA cluster.

The fix changes HasHighlyAvailableControlPlane to use AllInstanceGroups
since HA status is a cluster-wide property, not specific to filtered
instance groups.

Signed-off-by: Peter Kubicsek <peter.kubicsek@happening.xyz>
@pkubicsek-sb pkubicsek-sb force-pushed the fix-ha-detection-with-instance-group-filter branch from c3189b5 to e6786c2 Compare November 3, 2025 18:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 3, 2025
@hakman
Copy link
Member

hakman commented Nov 4, 2025

Thanks for looking into this @pkubicsek-sb.
/cc @justinsb
/ok-to-test

@k8s-ci-robot k8s-ci-robot requested a review from justinsb November 4, 2025 16:22
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2025
@hakman hakman removed the request for review from johngmyers November 4, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

@justinsb justinsb Awaiting requested review from justinsb

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HasHighlyAvailableControlPlane incorrectly uses filtered instance groups

3 participants

@pkubicsek-sb @k8s-ci-robot @hakman