fix allowing inclusion of functions.php multiple time #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgloeggl please resubmit this to the 2.0 branch of assetic-php/assetic. @jaxwilko if @tgloeggl doesn't want to, could you implement this? |
Author
I would gladly but that does not seem to be necessary in that mentioned branch as all functions are separately gated (instead of my lazy variant of that) and multiple inclusions of functions.php should not result in an error anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current usage of function_exists does not allow for multiple inclusion of functions.php, see
http://php.net/manual/de/function.function-exists.php#110163
The diff is a bit messy, i simply negated the if-call, put all functions into the if block and corrected the indentation.