Skip to content

Fix commentless filter #758 #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AlexAsh wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix commentless filter #758 #759

AlexAsh wants to merge 13 commits into from

Conversation

@AlexAsh
Copy link
Contributor

@AlexAsh AlexAsh commented Oct 6, 2015

This fixes issue #758 with CSS and also LESS filterCommentless.
Also broken test ScssphpFilterTest::testCompassExtensionCanBeDisabled fixed.

Possibly it worth moving from regexps to lexers/parsers for language processing (CSS, LESS etc.) in future.

@AlexAsh
Copy link
Contributor Author

AlexAsh commented Oct 6, 2015

Btw, travis build contains errors from master.
Should I fix them before my pull request will be reviewed?

@kriswallsmith
Copy link
Owner

kriswallsmith commented Oct 6, 2015

Yes, if you could submit a pull request with fixes for master that would be
much appreciated.

On Tue, 6 Oct 2015 at 11:11 AlexAsh notifications@github.com wrote:

Btw, travis build contains errors from master.
Should I fix them before my pull request will be reviewed?

—
Reply to this email directly or view it on GitHub
#759 (comment)
.

@AlexAsh
Copy link
Contributor Author

AlexAsh commented Oct 9, 2015

Now build passes (except one HHVM-related issue) and pull request is ready for review :-)

@stof
Copy link
Collaborator

stof commented Oct 9, 2015

@AlexAsh please submit the test fixes for master in a separate PR, so that it can be merged much quickly than the big refactoring done in this PR.

@AlexAsh
Copy link
Contributor Author

AlexAsh commented Oct 9, 2015

Done. So if build fixing PR will be merged should I rebase & push -f this branch?

@stof
Copy link
Collaborator

stof commented Nov 5, 2015

@AlexAsh yes, please rebase this branch

AlexAsh added 13 commits November 5, 2015 16:18
@AlexAsh
Failing test for CssUtils::filterCommentless bug refs kriswallsmith#758
e497767
@AlexAsh
State class for state-based text analyzer refs kriswallsmith#758
4a2ef83
@AlexAsh
Tests for AnalyzerState class refs kriswallsmith#758
560882e
@AlexAsh
State-based CSS analyzer refs kriswallsmith#758
405e80e
@AlexAsh
Tests for CssAnalyzer class refs kriswallsmith#758
a5627b0
@AlexAsh
Implement correct comment filtering for CSS refs kriswallsmith#758
efb9d01
@AlexAsh
Changed LessUtils::filterCommentless base test to correspond CssUtils…
32701af 
…::filterCommentless test refs kriswallsmith#758
@AlexAsh
Changed failing test LessUtilsTest::testFilterCommentlessLess to be m…
f8fce9e 
…ore catchall refs kriswallsmith#758
@AlexAsh
State-based LESS analyzer refs kriswallsmith#758
fd271d4
@AlexAsh
Implement correct comment filtering for LESS refs kriswallsmith#758
78a871b
@AlexAsh
Repaired autoprefixer cli dependency (@see https://github.com/postcss…
23f5aa3 
…/autoprefixer/releases/tag/6.0.0)
@AlexAsh
Autoprefixer legacy wrapper
e1776a5
@AlexAsh
Autoprefixer binary usage
49153bc
@AlexAsh AlexAsh force-pushed the fix_comment_filter_#758 branch from a91647d to 49153bc Compare November 5, 2015 13:55
@andrewtch andrewtch mentioned this pull request Jan 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexAsh @kriswallsmith @stof