-
-
Notifications
You must be signed in to change notification settings - Fork 403
Add Pydantic v1 to the test matrix #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Pydantic v1 to the test matrix #2515
Conversation
$ tox r -e lock
ROOT: will run in automatically provisioned tox, host /usr/bin/python is missing [requires (has)]: tox>=4.24.1 (4.23.2), tox-uv>=1.23
ROOT: provision> .tox/.tox/bin/python -m tox r -e lock
lock: commands[0]> uv lock --refresh --upgrade
Using CPython 3.12.11
× No solution found when resolving dependencies for split (markers: python_full_version >= '3.10'; included: datamodel-code-generator[group:pydantic1]; excluded:
│ datamodel-code-generator[group:black22], datamodel-code-generator[group:black23], datamodel-code-generator[group:black24], datamodel-code-generator[group:dev]):
╰─▶ Because datamodel-code-generator:pkg-meta depends on check-wheel-contents>=0.6.1 and only the following versions of check-wheel-contents are available:
check-wheel-contents<=0.6.1
check-wheel-contents==0.6.2
check-wheel-contents==0.6.3
we can conclude that datamodel-code-generator:pkg-meta depends on check-wheel-contents>=0.6.1.
And because check-wheel-contents>=0.6.1 depends on pydantic>=2.0 and datamodel-code-generator:pydantic1 depends on pydantic<2, we can conclude that datamodel-code-generator:pydantic1 and
datamodel-code-generator:pkg-meta are incompatible.
And because your project requires datamodel-code-generator:pkg-meta and datamodel-code-generator:pydantic1, we can conclude that your project's requirements are unsatisfiable.
lock: exit 1 (1.33 seconds) ../datamodel-code-generator> uv lock --refresh --upgrade pid=237059
lock: FAIL code 1 (1.35=setup[0.01]+cmd[1.33] seconds)
evaluation failed :( (1.40 seconds) |
|
@gaborbernat @koxudaxi see #2516. I propose to merge this PR to keep track of the incompatibility in the |
CodSpeed Performance ReportMerging #2515 will degrade performances by 20.66%Comparing 🎉 Hooray!
|
|
Draft until I fix the issues with CI for Python 3.14 |
eaa7bc5 to
d962270
Compare
be1756d to
016c345
Compare
for more information, see https://pre-commit.ci
…t prance versions
We don't run any test about how the code base runs with Pydantic v1, even if it's supposed to be supported.
In fact, the implementations for Pydantic v1 is broken. See #2516.