add dataclass arguments #2437
add dataclass arguments #2437
Conversation
Added dataclass_arguments and tests
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #2437 will not alter performanceComparing Summary
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Khaled Radmal <khaled>
* fix ci * added # noqa: UP045 --------- Co-authored-by: Khaled Radmal <khaled>
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
- Coverage 97.67% 97.62% -0.06%
==========================================
Files 67 67
Lines 8128 8195 +67
Branches 854 863 +9
==========================================
+ Hits 7939 8000 +61
Misses 144 144
- Partials 45 51 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
You'll need to fix the readme failure:
diff --git a/README.md b/README.md
index e7d4b968..5347439b 100644
--- a/README.md
+++ b/README.md
@@ -495,7 +495,7 @@ Template customization:
A file with kwargs for custom formatters.
--custom-template-dir CUSTOM_TEMPLATE_DIR
Custom template directory
- --encoding ENCODING The encoding of input and output (default: cp1252)
+ --encoding ENCODING The encoding of input and output (default: utf-8)
--extra-template-data EXTRA_TEMPLATE_DATA
Extra template data
--use-double-quotes Model generated with double quotes. Single quotes or your black
diff --git a/docs/index.md b/docs/index.md
index 0cc303ab..478dd24a 100644
--- a/docs/index.md
+++ b/docs/index.md
@@ -487,7 +487,7 @@ Template customization:
A file with kwargs for custom formatters.
--custom-template-dir CUSTOM_TEMPLATE_DIR
Custom template directory
- --encoding ENCODING The encoding of input and output (default: cp1252)
+ --encoding ENCODING The encoding of input and output (default: utf-8)
--extra-template-data EXTRA_TEMPLATE_DATA
Extra template data
--use-double-quotes Model generated with double quotes. Single quotes or your blackOtherwise looks good.
| A file with kwargs for custom formatters. | ||
| --custom-template-dir CUSTOM_TEMPLATE_DIR | ||
| Custom template directory | ||
| --encoding ENCODING The encoding of input and output (default: utf-8) |
There was a problem hiding this comment.
Why has this line has changed? I can't find any edit related to default file encoding
There was a problem hiding this comment.
Yeah the CI is breaking because of this, my guess is that the readme generator behaves differently on Windows and UNIX, and the PR creator ran it on Windows causing this change.
There was a problem hiding this comment.
OT: I wonder if we should set a default encoding instead of relying on the system default/
Or we could specify that it's the SYSTEM default (and it's not enforced by the tool)
| A file with kwargs for custom formatters. | ||
| --custom-template-dir CUSTOM_TEMPLATE_DIR | ||
| Custom template directory | ||
| --encoding ENCODING The encoding of input and output (default: utf-8) |
There was a problem hiding this comment.
Yeah the CI is breaking because of this, my guess is that the readme generator behaves differently on Windows and UNIX, and the PR creator ran it on Windows causing this change.
Co-authored-by: Antonio Spadaro <ilovelinux@users.noreply.github.com>
|
@ICEPower420 can you address the coverage issues? Thanks! |
Sorry have been a bit preoccupied lately. Hope to get to it somewhere this week. |
4 participants
Resolves feature: adding parameter to @DataClass() #2357
Added argument dataclass_arguments takes precedence over --keyword-only and --frozen-dataclasses