Harden subprocess calls in bulk_generate_mad.py against command injection#7
Draft
Copilot wants to merge 3 commits into
Draft
Harden subprocess calls in bulk_generate_mad.py against command injection#7Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
- Added comprehensive docstring with security expectations - Validate language parameter against whitelist of supported CodeQL languages - Validate extractor_options type and content (must be iterable of strings) - Explicitly set shell=False in all subprocess calls - Added detailed security comments referencing OWASP and Python docs - All changes formatted with Black Co-authored-by: dmsmi <6402178+dmsmi@users.noreply.github.com>
- Remove exception details from error messages to avoid exposing internal details - Remove option values from error messages to prevent potential log exposure - Use descriptive variable name 'extractor_option' instead of 'x' in comprehension Co-authored-by: dmsmi <6402178+dmsmi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor build_database to enhance subprocess security
Harden subprocess calls in bulk_generate_mad.py against command injection
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthens subprocess usage in
build_databasefunction to prevent command injection vulnerabilities through explicit security controls and input validation.Changes
languageparameter against known CodeQL languages (cpp, csharp, go, java, javascript, python, ruby, rust, swift); validateextractor_optionsas string-only iterableshell=Falseexplicitly in all subprocess calls (build_database, clone_project, gitroot)Example
Before:
After:
Defense-in-depth approach: validates config file inputs despite trusted source, prevents regression from future refactoring.
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.