Skip to content

Fix Revision readiness when image cache reconciliation fails - #16723

Open
saylee21 wants to merge 1 commit into
knative:mainfrom
saylee21:fix-imagecache-pa-reconcile
Open

Fix Revision readiness when image cache reconciliation fails#16723
saylee21 wants to merge 1 commit into
knative:mainfrom
saylee21:fix-imagecache-pa-reconcile

Conversation

@saylee21

@saylee21 saylee21 commented Oct 22, 2026

Copy link
Copy Markdown

Fixes #16649

Proposed Changes

  • Reconcile the PodAutoscaler even when image cache reconciliation fails, so a Revision with available Deployment resources cannot remain Ready below its initial scale.
  • Preserve both reconciliation errors with errors.Join.
  • Add a regression test that induces an image cache create failure and verifies the Revision is marked not ready with ResourcesAvailable and Active unknown.

The image cache is an optimization. A failure to create it should not prevent the PodAutoscaler from reporting that the Revision is still deploying.

Release Note

Fix a bug where a Revision could remain Ready below its initial scale when image cache reconciliation failed.

@saylee21
Fix Revision readiness when image cache reconciliation fails
729720c 
Signed-off-by: Saylee <saylee21@users.noreply.github.com>
@knative-prow

knative-prow Bot commented Oct 22, 2026

Copy link
Copy Markdown

Welcome @saylee21! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2026
@knative-prow knative-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2026
@knative-prow

knative-prow Bot commented Oct 22, 2026

Copy link
Copy Markdown

Hi @saylee21. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow

knative-prow Bot commented Oct 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saylee21
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson
@matzew matzew Awaiting requested review from matzew
@skonto skonto Awaiting requested review from skonto

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Route promotes a Revision to 100% traffic while it is still below initial-scale (latestReadyRevision latches an under-scaled Revision)

1 participant

@saylee21