Repository navigation
fix: treat LRR-failed-but-LCR-different as transient in traffic config - #16702
higgsboson1710 wants to merge 1 commit into
Conversation
|
|
|
Welcome @higgsboson1710! It looks like this is your first PR to knative/serving 🎉 |
|
Hi @higgsboson1710. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: higgsboson1710 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes: #16698
When a Knative revision fails, the following state can occur in the Configuration:
In this state, the Route controller's addConfigurationTarget would:
This caused the Route to become permanently stuck even when a new revision
(rev-v3) is actively being deployed to replace the failed one. The Route would
not automatically recover — users had to manually delete the failed Revision
to force a re-reconciliation.
The fix: in addConfigurationTarget, before calling errUnreadyRevision when the
LRR revision is found to be failed, check if LCR != LRR. If they differ, a new
revision is in flight, so we should return errUnreadyConfiguration instead —
which produces isFailure=false and lets the Route retry gracefully.