-
Notifications
You must be signed in to change notification settings - Fork 199
Expand file tree
/
Copy pathe2e_trigger_sync_test.go
More file actions
545 lines (451 loc) · 15.4 KB
/
e2e_trigger_sync_test.go
File metadata and controls
545 lines (451 loc) · 15.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
//go:build e2e
package e2e
import (
"encoding/json"
"fmt"
"os"
"os/exec"
"strings"
"testing"
"time"
fn "knative.dev/func/pkg/functions"
)
// TestMetadata_TriggerSyncStaleTriggerCleanup verifies that stale triggers are deleted
// when subscriptions are removed from func.yaml
func TestMetadata_TriggerSyncStaleTriggerCleanup(t *testing.T) {
brokerName := "default"
createBrokerWithCheck(t, Namespace, brokerName)
functionName := "func-e2e-test-trigger-sync-cleanup"
root := fromCleanEnv(t, functionName)
// Create function
if err := newCmd(t, "init", "-l=go", "-t=http").Run(); err != nil {
t.Fatal(err)
}
// Add first subscription
if err := newCmd(t, "subscribe",
"--source", "default",
"--filter", "type=order.created").Run(); err != nil {
t.Fatal(err)
}
// Add second subscription by editing func.yaml
f, err := fn.NewFunction(root)
if err != nil {
t.Fatal(err)
}
// Add another subscription manually
f.Deploy.Subscriptions = append(f.Deploy.Subscriptions, fn.KnativeSubscription{
Source: "default",
Filters: map[string]string{
"type": "order.updated",
},
})
if err := f.Write(); err != nil {
t.Fatal(err)
}
// Deploy with raw deployer
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
defer clean(t, functionName, Namespace)
waitForDeployment(t, Namespace, functionName)
// Verify 2 triggers were created
triggers := listTriggersForFunction(t, Namespace, functionName)
if len(triggers) != 2 {
t.Fatalf("Expected 2 triggers after initial deploy, got %d: %v", len(triggers), triggers)
}
t.Logf("Initial deploy created 2 triggers: %v", triggers)
// Verify triggers have managed-by annotation
for _, trigger := range triggers {
if !hasManagedByAnnotation(t, Namespace, trigger) {
t.Errorf("Trigger %s missing managed-by annotation", trigger)
}
}
t.Log("All triggers have managed-by annotation")
// Remove one subscription by editing func.yaml
f, err = fn.NewFunction(root)
if err != nil {
t.Fatal(err)
}
// Keep only the first subscription
f.Deploy.Subscriptions = f.Deploy.Subscriptions[:1]
if err := f.Write(); err != nil {
t.Fatal(err)
}
// Redeploy
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
time.Sleep(5 * time.Second)
// Verify only 1 trigger remains
triggersAfter := listTriggersForFunction(t, Namespace, functionName)
if len(triggersAfter) != 1 {
t.Fatalf("Expected 1 trigger after removing subscription, got %d: %v", len(triggersAfter), triggersAfter)
}
t.Logf("Stale trigger deleted, 1 trigger remains: %v", triggersAfter)
}
// TestMetadata_TriggerSyncManualTriggerPreservation verifies that manually created
// triggers (without managed-by annotation) are NOT deleted during sync
func TestMetadata_TriggerSyncManualTriggerPreservation(t *testing.T) {
brokerName := "default"
createBrokerWithCheck(t, Namespace, brokerName)
functionName := "func-e2e-test-trigger-sync-manual"
_ = fromCleanEnv(t, functionName)
// Create function
if err := newCmd(t, "init", "-l=go", "-t=http").Run(); err != nil {
t.Fatal(err)
}
// Add one subscription
if err := newCmd(t, "subscribe",
"--source", "default",
"--filter", "type=order.created").Run(); err != nil {
t.Fatal(err)
}
// Deploy with raw deployer
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
defer clean(t, functionName, Namespace)
waitForDeployment(t, Namespace, functionName)
// Create a manual trigger (without managed-by annotation)
manualTriggerName := fmt.Sprintf("%s-manual-trigger", functionName)
createManualTrigger(t, Namespace, manualTriggerName, functionName, brokerName)
// Verify we have 2 triggers (1 managed + 1 manual)
allTriggers := listAllTriggers(t, Namespace)
managedTriggers := listTriggersForFunction(t, Namespace, functionName)
if len(managedTriggers) != 1 {
t.Fatalf("Expected 1 managed trigger, got %d", len(managedTriggers))
}
if len(allTriggers) < 2 {
t.Fatalf("Expected at least 2 total triggers (managed + manual), got %d", len(allTriggers))
}
t.Logf("Created manual trigger: %s", manualTriggerName)
// Redeploy (no changes to subscriptions)
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
time.Sleep(5 * time.Second)
// Verify manual trigger still exists
if !triggerExists(t, Namespace, manualTriggerName) {
t.Fatal("Manual trigger was deleted during sync - should have been preserved!")
}
t.Log("Manual trigger preserved after redeploy")
// Verify managed trigger still exists
managedTriggersAfter := listTriggersForFunction(t, Namespace, functionName)
if len(managedTriggersAfter) != 1 {
t.Fatalf("Expected 1 managed trigger after redeploy, got %d", len(managedTriggersAfter))
}
t.Log("Managed trigger still exists")
}
// TestMetadata_TriggerSyncAddSubscription verifies that new triggers are created
// when subscriptions are added
func TestMetadata_TriggerSyncAddSubscription(t *testing.T) {
brokerName := "default"
createBrokerWithCheck(t, Namespace, brokerName)
functionName := "func-e2e-test-trigger-sync-add"
root := fromCleanEnv(t, functionName)
// Create function
if err := newCmd(t, "init", "-l=go", "-t=http").Run(); err != nil {
t.Fatal(err)
}
// Add one subscription
if err := newCmd(t, "subscribe",
"--source", "default",
"--filter", "type=order.created").Run(); err != nil {
t.Fatal(err)
}
// Deploy with raw deployer
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
defer clean(t, functionName, Namespace)
waitForDeployment(t, Namespace, functionName)
// Verify 1 trigger created
triggers := listTriggersForFunction(t, Namespace, functionName)
if len(triggers) != 1 {
t.Fatalf("Expected 1 trigger, got %d", len(triggers))
}
t.Logf("Initial deploy created 1 trigger: %v", triggers)
// Add another subscription by editing func.yaml
f, err := fn.NewFunction(root)
if err != nil {
t.Fatal(err)
}
f.Deploy.Subscriptions = append(f.Deploy.Subscriptions, fn.KnativeSubscription{
Source: "default",
Filters: map[string]string{
"type": "order.shipped",
},
})
if err := f.Write(); err != nil {
t.Fatal(err)
}
// Redeploy
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
time.Sleep(5 * time.Second)
// Verify 2 triggers now exist
triggersAfter := listTriggersForFunction(t, Namespace, functionName)
if len(triggersAfter) != 2 {
t.Fatalf("Expected 2 triggers after adding subscription, got %d: %v", len(triggersAfter), triggersAfter)
}
t.Logf("New trigger created, 2 triggers total: %v", triggersAfter)
}
// TestMetadata_TriggerSyncIdempotency verifies that repeated deploys with the same
// subscriptions don't create duplicate triggers
func TestMetadata_TriggerSyncIdempotency(t *testing.T) {
brokerName := "default"
createBrokerWithCheck(t, Namespace, brokerName)
functionName := "func-e2e-test-trigger-sync-idempotent"
root := fromCleanEnv(t, functionName)
// Create function
if err := newCmd(t, "init", "-l=go", "-t=http").Run(); err != nil {
t.Fatal(err)
}
// Add first subscription
if err := newCmd(t, "subscribe",
"--source", "default",
"--filter", "type=order.created").Run(); err != nil {
t.Fatal(err)
}
// Add second subscription by editing func.yaml
f, err := fn.NewFunction(root)
if err != nil {
t.Fatal(err)
}
f.Deploy.Subscriptions = append(f.Deploy.Subscriptions, fn.KnativeSubscription{
Source: "default",
Filters: map[string]string{
"type": "order.updated",
},
})
if err := f.Write(); err != nil {
t.Fatal(err)
}
// Deploy with raw deployer
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
defer clean(t, functionName, Namespace)
waitForDeployment(t, Namespace, functionName)
// Verify 2 triggers created
triggers := listTriggersForFunction(t, Namespace, functionName)
if len(triggers) != 2 {
t.Fatalf("Expected 2 triggers, got %d", len(triggers))
}
initialTriggers := make([]string, len(triggers))
copy(initialTriggers, triggers)
t.Logf("Initial triggers: %v", initialTriggers)
// Redeploy multiple times
for i := 1; i <= 3; i++ {
t.Logf("Redeploy #%d", i)
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
time.Sleep(3 * time.Second)
triggersAfter := listTriggersForFunction(t, Namespace, functionName)
if len(triggersAfter) != 2 {
t.Fatalf("Redeploy #%d: Expected 2 triggers, got %d: %v", i, len(triggersAfter), triggersAfter)
}
// Verify trigger names haven't changed
if !equalStringSlices(initialTriggers, triggersAfter) {
t.Fatalf("Redeploy #%d: Trigger names changed! Initial: %v, After: %v", i, initialTriggers, triggersAfter)
}
}
t.Log("Idempotency verified: 3 redeploys produced same triggers")
}
// TestMetadata_TriggerSyncRemoveAllSubscriptions verifies that all managed triggers
// are deleted when all subscriptions are removed
func TestMetadata_TriggerSyncRemoveAllSubscriptions(t *testing.T) {
brokerName := "default"
createBrokerWithCheck(t, Namespace, brokerName)
functionName := "func-e2e-test-trigger-sync-remove-all"
root := fromCleanEnv(t, functionName)
// Create function
if err := newCmd(t, "init", "-l=go", "-t=http").Run(); err != nil {
t.Fatal(err)
}
// Add first subscription
if err := newCmd(t, "subscribe",
"--source", "default",
"--filter", "type=order.created").Run(); err != nil {
t.Fatal(err)
}
// Add second subscription by editing func.yaml
f, err := fn.NewFunction(root)
if err != nil {
t.Fatal(err)
}
f.Deploy.Subscriptions = append(f.Deploy.Subscriptions, fn.KnativeSubscription{
Source: "default",
Filters: map[string]string{
"type": "order.updated",
},
})
if err := f.Write(); err != nil {
t.Fatal(err)
}
// Deploy with raw deployer
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
defer clean(t, functionName, Namespace)
waitForDeployment(t, Namespace, functionName)
// Verify 2 triggers created
triggers := listTriggersForFunction(t, Namespace, functionName)
if len(triggers) != 2 {
t.Fatalf("Expected 2 triggers, got %d", len(triggers))
}
t.Logf("Initial triggers: %v", triggers)
// Create a manual trigger for comparison
manualTriggerName := fmt.Sprintf("%s-manual", functionName)
createManualTrigger(t, Namespace, manualTriggerName, functionName, brokerName)
// Remove all subscriptions by editing func.yaml directly
f, err = fn.NewFunction(root)
if err != nil {
t.Fatal(err)
}
f.Deploy.Subscriptions = []fn.KnativeSubscription{}
if err := f.Write(); err != nil {
t.Fatal(err)
}
// Redeploy
if err := newCmd(t, "deploy", "--deployer", "raw").Run(); err != nil {
t.Fatal(err)
}
time.Sleep(5 * time.Second)
// Verify no managed triggers remain
managedTriggersAfter := listTriggersForFunction(t, Namespace, functionName)
if len(managedTriggersAfter) != 0 {
t.Fatalf("Expected 0 managed triggers after removing all subscriptions, got %d: %v", len(managedTriggersAfter), managedTriggersAfter)
}
t.Log("All managed triggers deleted")
// Verify manual trigger still exists
if !triggerExists(t, Namespace, manualTriggerName) {
t.Fatal("Manual trigger was deleted - should have been preserved!")
}
t.Log("Manual trigger preserved")
}
// Helper functions
// listTriggersForFunction lists all triggers with managed-by annotation for a function
func listTriggersForFunction(t *testing.T, namespace, functionName string) []string {
t.Helper()
// Get all triggers in namespace (kubectl doesn't support annotation selectors)
cmd := exec.Command("kubectl", "get", "triggers", "-n", namespace,
"-o", "json")
cmd.Env = append(os.Environ(), "KUBECONFIG="+Kubeconfig)
output, err := cmd.CombinedOutput()
if err != nil {
t.Logf("Warning: could not list triggers: %v, output: %s", err, string(output))
return []string{}
}
// Parse JSON to filter by annotation
var triggerList struct {
Items []struct {
Metadata struct {
Name string `json:"name"`
Annotations map[string]string `json:"annotations"`
} `json:"metadata"`
} `json:"items"`
}
if err := json.Unmarshal(output, &triggerList); err != nil {
t.Logf("Warning: could not parse triggers JSON: %v", err)
return []string{}
}
// Filter triggers that:
// 1. Have the managed-by annotation
// 2. Belong to this function (name starts with functionName-trigger-)
var functionTriggers []string
for _, trigger := range triggerList.Items {
if trigger.Metadata.Annotations["func.knative.dev/managed-by"] == "func-raw-deployer" {
if strings.HasPrefix(trigger.Metadata.Name, functionName+"-trigger-") {
functionTriggers = append(functionTriggers, trigger.Metadata.Name)
}
}
}
return functionTriggers
}
// listAllTriggers lists all triggers in namespace
func listAllTriggers(t *testing.T, namespace string) []string {
t.Helper()
cmd := exec.Command("kubectl", "get", "triggers", "-n", namespace,
"-o", "jsonpath={.items[*].metadata.name}")
cmd.Env = append(os.Environ(), "KUBECONFIG="+Kubeconfig)
output, err := cmd.CombinedOutput()
if err != nil {
t.Logf("Warning: could not list all triggers: %v", err)
return []string{}
}
triggersStr := strings.TrimSpace(string(output))
if triggersStr == "" {
return []string{}
}
return strings.Fields(triggersStr)
}
// hasManagedByAnnotation checks if a trigger has the managed-by annotation
func hasManagedByAnnotation(t *testing.T, namespace, triggerName string) bool {
t.Helper()
cmd := exec.Command("kubectl", "get", "trigger", triggerName, "-n", namespace,
"-o", "jsonpath={.metadata.annotations.func\\.knative\\.dev/managed-by}")
cmd.Env = append(os.Environ(), "KUBECONFIG="+Kubeconfig)
output, err := cmd.CombinedOutput()
if err != nil {
t.Logf("Warning: could not get trigger annotation: %v", err)
return false
}
return strings.TrimSpace(string(output)) == "func-raw-deployer"
}
// createManualTrigger creates a trigger without the managed-by annotation
func createManualTrigger(t *testing.T, namespace, triggerName, functionName, brokerName string) {
t.Helper()
triggerYAML := fmt.Sprintf(`apiVersion: eventing.knative.dev/v1
kind: Trigger
metadata:
name: %s
namespace: %s
# Note: NO managed-by annotation
spec:
broker: %s
subscriber:
uri: http://%s.%s.svc.cluster.local
filter:
attributes:
type: manual.event
`, triggerName, namespace, brokerName, functionName, namespace)
cmd := exec.Command("kubectl", "apply", "-f", "-")
cmd.Stdin = strings.NewReader(triggerYAML)
cmd.Env = append(os.Environ(), "KUBECONFIG="+Kubeconfig)
output, err := cmd.CombinedOutput()
if err != nil {
t.Fatalf("Failed to create manual trigger: %v, output: %s", err, string(output))
}
t.Cleanup(func() {
deleteCmd := exec.Command("kubectl", "delete", "trigger", triggerName, "-n", namespace, "--ignore-not-found")
deleteCmd.Env = append(os.Environ(), "KUBECONFIG="+Kubeconfig)
_ = deleteCmd.Run()
})
t.Logf("Created manual trigger: %s", triggerName)
}
// triggerExists checks if a trigger exists
func triggerExists(t *testing.T, namespace, triggerName string) bool {
t.Helper()
cmd := exec.Command("kubectl", "get", "trigger", triggerName, "-n", namespace)
cmd.Env = append(os.Environ(), "KUBECONFIG="+Kubeconfig)
return cmd.Run() == nil
}
// equalStringSlices checks if two string slices contain the same elements (order-independent)
func equalStringSlices(a, b []string) bool {
if len(a) != len(b) {
return false
}
aMap := make(map[string]bool)
for _, s := range a {
aMap[s] = true
}
for _, s := range b {
if !aMap[s] {
return false
}
}
return true
}