Skip to content

Conversation

@MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 10, 2025

See kiwix/java-libkiwix#130

  • Introduced the show_search_suggestions_spellchecked key in the info.json file for custom apps. When set to true, it displays alternative suggestions when the user enters a misspelled search term.
  • Updated the README file to document this new key.
  • Enabled this feature by default for the DWDS app.

@kelson42
Copy link
Contributor

Please rename the param like on apple

@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliFtechiz MohitMaliFtechiz changed the title Introduced the show_search_suggestions key in the info.json file. Introduced the show_search_suggestions_spellchecked key in the info.json file. Nov 10, 2025
…o.json` file for custom apps. When set to `true`, it displays alternative suggestions when the user enters a misspelled search term.

* Updated the README file to document this new key.
* Enabled this feature by default for the `DWDS` app.
@MohitMaliFtechiz MohitMaliFtechiz force-pushed the introduced_enabling_search_correction branch from fcebc2f to 75e64f3 Compare November 10, 2025 07:22
@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 Changes done.

@kelson42
Copy link
Contributor

kelson42 commented Nov 10, 2025

where is the logic to do the spell checking or not... this is only the readme? Why we have this pr ready before java-libkiwix is released?

@MohitMaliFtechiz
Copy link
Collaborator Author

where is the logic to do the spell checking or not...

@kelson42 This logic is placed in the kiwix-android(in this PR kiwix/kiwix-android#4445).

this is only the readme?

It is for giving information about the attribute so that in other app we need this functionality it can easily enable by setting this key for that custom app.

Why we have this pr ready before java-libkiwix is released?

This is only a configuration for custom app. The acutal implementation is written in kiwix/kiwix-android#4445 and that PR depeneds on java-libkiwix, i have updated this thing in PR comments.

@kelson42 kelson42 merged commit 31bd275 into main Nov 11, 2025
4 checks passed
@kelson42 kelson42 deleted the introduced_enabling_search_correction branch November 11, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants