android: Upgrade Hardware.java APIs for API 26+/23+/24+ compatibility - #3380
Open
Novfensec wants to merge 4 commits into
Open
android: Upgrade Hardware.java APIs for API 26+/23+/24+ compatibility#3380Novfensec wants to merge 4 commits into
Novfensec wants to merge 4 commits into
Conversation
Contributor
Author
|
I did spotless with different version but I don't know which version this expects. And So there should be a pre-commit hook that applies spotless as expected itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Hardware.javato use modern Android APIs, replacing severaldeprecated calls that produce lint warnings on API 26+ targets.
Changes
Vibration (
vibrate)VibrationEffect.createOneShot()on API 26+Vibrator.vibrate(long)on older devicesNetwork detection (
checkNetwork)ConnectivityManager.getActiveNetwork()+NetworkCapabilitieson API 23+ instead of the deprecated
getActiveNetworkInfo()Network listener (
registerNetworkCheck)ConnectivityManager.NetworkCallbackon API 24+instead of the deprecated
CONNECTIVITY_ACTIONbroadcastContext / View access
contextandviewaspublic(were package-private)getContext()helper that falls back toPythonActivity.mActivitygetView()helper that falls back to the activity's decor viewWiFi scanning (
enableWifiScanner)WifiManagerviagetApplicationContext()(avoids memory leakwith non-application contexts)
getScanResults()in aSecurityExceptioncatch block(required permission
ACCESS_FINE_LOCATIONon API 29+)Misc
String +=concatenation loops withStringBuilder(float[])casts onreadSensor()return valuessSensor == nullguard inchangeStatus()for devices that lacka particular sensor type
Testing