Remove redundant class variable definition from recipes#2938
Open
shyamnathp wants to merge 2 commits intokivy:developfrom
Open
Remove redundant class variable definition from recipes#2938shyamnathp wants to merge 2 commits intokivy:developfrom
shyamnathp wants to merge 2 commits intokivy:developfrom
Conversation
Contributor
shyamnathp
commented
Dec 8, 2023
shyamnathp
commented
- Some of the variables like call_hostpython_via_targetpython, install_in_hostpython are redifined in the package recipes with the exact same value as its parent class, making the definitions redundant. This patch removes these redefinitions.
- Some of the variables like call_hostpython_via_targetpython, install_in_hostpython are redifined in the package recipes with the exact same value as its parent class, making the definitions redundant. This patch removes this redefinitions.
Contributor
Author
|
feel free to abandon this PR if the variables were redefined originally for readability reasons. |
Member
|
Thanks for the cleanup @shyamnathp , however, the CI is failing. The good news is that I'm 100% sure is not your fault, but in order to have a ✅ , can you please add |
- breaks the CI
Contributor
Author
As a part of understanding the logs, how did you figure out it was 'pygame' that was causing the crash? From the logs, I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.