Recipe for pydantic #2480
Recipe for pydantic #2480
Conversation
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Good start, a few easy things to fix.
I haven't tested the recipe runtime so you will be the one to tell if it works
| version = '1.8.2' | ||
| url = 'https://github.com/samuelcolvin/pydantic.git' | ||
| depends = ['setuptools'] | ||
| python_depends = ['Cython==0.29.23', 'devtools==0.6.1', 'email-validator==1.1.2','dataclasses==0.6', 'typing-extensions==3.10.0.0', 'python-dotenv==0.17.1'] |
There was a problem hiding this comment.
I would not pin the versions here, but rather at installation time e.g. from the buildozer.spec file.
So here you just put the dependencies without the versions
|
Is everything right now? |
|
@AndreMiras you have to approve the CI for first-time contributors before it will run. |
|
@FilipeMarch have you tested the recipe? |
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Think look better indeed, but pipeline failed because of a linting issue.
Simply add a white space in your python_depends list between 'email-validator' and 'dataclasses'.
I can also do the edit myself if you prefer.
Also if you know how to squash your commits so your PR is only one commit perfect, otherwise we'll try to think about it upon merge
| version = '1.8.2' | ||
| url = 'https://github.com/samuelcolvin/pydantic/archive/refs/tags/v{version}.zip' | ||
| depends = ['setuptools'] | ||
| python_depends = ['Cython', 'devtools', 'email-validator','dataclasses', 'typing-extensions', 'python-dotenv'] |
There was a problem hiding this comment.
Minor linter issue here it seems:
pythonforandroid/recipes/pydantic/__init__.py:8:62: E231 missing whitespace after ','
Let's fix it so the pipeline runs fully
There was a problem hiding this comment.
Also if you know how to squash your commits so your PR is only one commit perfect, otherwise we'll try to think about it upon merge
I am searching everywhere here in the Github interface and I can't find where to squash my commits.
Is it possible to do it from github.com interface or do I need to clone the repo and so on?
There was a problem hiding this comment.
Thanks for looking into it.
I'm not aware of how to do it from GitHub.
I usually do it from the command line using either git rebase -i... or git reset --soft HEAD~....
I'll squash upon merge then
|
Sorry to bother, is there any chance you guys could update me if it's correct now that I have added the missing whitespace? |
3 participants
My Kivy application is using pydantic to handle dataclasses and enforcing strong typing.
I am trying to create a recipe for it. I would really appreciate some help on this.
Is anything wrong?