Skip to content

Allow passing entrypoint and orientation through putExtra/getExtra when starting from another activity. #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tshirtman wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Allow passing entrypoint and orientation through putExtra/getExtra when starting from another activity. #1976

tshirtman wants to merge 3 commits into from

Conversation

@tshirtman
Copy link
Member

@tshirtman tshirtman commented Sep 1, 2019

No description provided.

@tshirtman tshirtman added the WIP label Sep 1, 2019
@tshirtman tshirtman changed the title wip allow passing entrypoint and orientation through putExtra/getExtra when starting from another activity. Sep 1, 2019
@tshirtman tshirtman changed the title allow passing entrypoint and orientation through putExtra/getExtra when starting from another activity. Allow passing entrypoint and orientation through putExtra/getExtra when starting from another activity. Sep 1, 2019
@opacam opacam mentioned this pull request Sep 1, 2019
Merged
@inclement
Copy link
Member

inclement commented Sep 15, 2019

I guess this is to support launcher interaction? Is it tested to work? I'm not certain there couldn't be some weird interactions with when/how sdl2 normally sets orientation.
It would be nice to abstract this out a bit differently, with a single "overrideDefaultsFromIntent" function call that puts everything in one place.

@kuzeyron kuzeyron added the core-providers Core code that's not a recipe label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core-providers Core code that's not a recipe WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tshirtman @inclement @kuzeyron