Skip to content

Conversation

@opacam
Copy link
Member

@opacam opacam commented Jun 7, 2019

Because this module isn't covered by our tests and this allow us to improve a little our coverage

AndreMiras
AndreMiras previously approved these changes Jun 7, 2019
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work thanks!
I'm waiting for the build to turn green before merging.

@opacam opacam changed the title Add unittest for module pythonforandroid.archs [WIP] Add unittest for module pythonforandroid.archs Jun 7, 2019
@opacam opacam changed the title [WIP] Add unittest for module pythonforandroid.archs Add unittest for module pythonforandroid.archs Jun 7, 2019
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@AndreMiras AndreMiras merged commit 352e4c7 into kivy:develop Jun 7, 2019
@opacam opacam deleted the unittest-archs branch June 15, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants